Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 19 pull requests #40357

Closed
wants to merge 43 commits into from
Closed

Rollup of 19 pull requests #40357

wants to merge 43 commits into from

Conversation

steveklabnik and others added 30 commits February 28, 2017 14:09
The args() and args_os() docs include a line about how the first element
is usually the program name. Include that line in the struct docs too.
Makes the sidebar a light grey and highlights the currently viewed item
in the sidebar more prominently.

All visual design credit goes to @johnwhelchel (rust-lang#37856)
I've been seeing failures on the bots when building jemalloc and my assumption
is that it's because cwd isn't created. That may be possible if this
`create_dir_all` call change in this commit fails, in which case we ignore the
error.

This commit updates the location to call `create_dir_racy` which handles
concurrent invocations, as multiple build scripts may be trying to create the
`native` dir.
…xcrichton

Extract nomicon to its own repo

part of rust-lang#39588

same as rust-lang#40213 but for the nomicon

r? @alexcrichton
… r=alexcrichton

Restore creating the channel-rust-$channel-date.txt files

I have **not** run this (because I don't know how to 😇), but it *does* compile.

r? @alexcrichton
Issue rust-lang#39688 - Help people find String::as_bytes() for UTF-8

Added in links for the inverse functions so people will know that as_bytes() is the inverse of from_utf8() and vice versa.
?r @steveklabnik
Fix description of closure coercion feature

Thanks to @whitequark for pointing this out.
…umeGomez

Improve the style of the sidebar in rustdoc output

Makes the sidebar a light grey and highlights the currently viewed item in the sidebar more prominently.

All visual design credit goes to @johnwhelchel (rust-lang#37856)

Sample screenshots:

![screen shot 2017-03-04 at 12 29 48 pm](https://cloud.githubusercontent.com/assets/831192/23580829/db6c26c2-00d6-11e7-8d89-822e25ba79f0.png)

![screen shot 2017-03-04 at 12 30 10 pm](https://cloud.githubusercontent.com/assets/831192/23580828/db69eeca-00d6-11e7-9f89-1e06fd3bf098.png)

![screen shot 2017-03-04 at 12 30 31 pm](https://cloud.githubusercontent.com/assets/831192/23580830/db6d00ce-00d6-11e7-89ca-cd03e148a121.png)
clarify docs for Args and ArgsOs

The args() and args_os() docs include a line about how the first element
is usually the program name. Include that line in the struct docs too.
Fix text formatting in README

There was a missing backtick in the README.
Remove extra space in test description (of a mod test)
Update libc to 0.2.21

Update to include android aarch64 and x86 improvements.
…turon

README formatting in configure/make section

Tiny change to render the `config.mk` correctly
Added remove_from to vec.rs (rust-lang#38143)

Turns out that if you push to someone's PR branch and cause the PR to close, you lose delegation 😞.

@madseagames I'm really sorry about that 😭
…chton

Update link to COMPILER_TESTS.md in CONTRIBUTING.md

Link to compiler test documentation was broken after the file was moved by rust-lang#40086.
This updates the link to the new location of the file.
…eklabnik

Document why `str.to_{lower,upper}case` return `String`

Fixes rust-lang#39201.
rustbuild: Assert directory creation succeeds

I've been seeing failures on the bots when building jemalloc and my assumption
is that it's because cwd isn't created. That may be possible if this
`create_dir_all` call change in this commit fails, in which case we ignore the
error.

This commit updates the location to call `create_dir_racy` which handles
concurrent invocations, as multiple build scripts may be trying to create the
`native` dir.
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member Author

frewsxcv commented Mar 8, 2017

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Mar 8, 2017

📌 Commit ed9e79b has been approved by frewsxcv

@bors
Copy link
Contributor

bors commented Mar 8, 2017

⌛ Testing commit ed9e79b with merge c4062c2...

@bors
Copy link
Contributor

bors commented Mar 8, 2017

💔 Test failed - status-travis

@frewsxcv frewsxcv closed this Mar 8, 2017
@frewsxcv frewsxcv deleted the rollup branch March 8, 2017 16:09
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.